Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (316dfc9) to head (4df21cb).
⚠️ Report is 4 commits behind head on stable-3.5.
✅ All tests successful. No failed tests found.

@@             Coverage Diff             @@
##           stable-3.5     #931   +/-   ##
===========================================
  Coverage       90.03%   90.03%           
===========================================
  Files             163      163           
  Lines           21896    21904    +8     
  Branches         2678     2678           
===========================================
+ Hits            19713    19721    +8     
  Misses           2183     2183           

@Joseph-Edwards can you reproduce the warnings that cause the one ci job to fail? I can't nor can I see any issues with the lines that it is complaining about.

@Joseph-Edwards can you reproduce the warnings that cause the one ci job to fail? I can't nor can I see any issues with the lines that it is complaining about.

I'll have a look now and report back

I can reproduce the errors. Will try and debug after my teaching at 1.

Looks like there's a bug in Catch2 v3.13.0 that is causing this failure. @Joseph-Edwards is going to open an issue about it.

I think I've found the bug. Opening a PR into Catch2 now, and will link here when it's done

I have just locally applied my patch to the new copy of Catch2 and it seems to fix the issues when building test-transf.hpp. @james-d-mitchell, do you think it's worth waiting for a new Catch2 release, or should we fix the issue locally ourselves?

I have just locally applied my patch to the new copy of Catch2 and it seems to fix the issues when building test-transf.hpp. @james-d-mitchell, do you think it's worth waiting for a new Catch2 release, or should we fix the issue locally ourselves?

Let's wait and see how quickly your issue with catch is picked up. We don't have to make the changes in this pr, so can wait

I have just locally applied my patch to the new copy of Catch2 and it seems to fix the issues when building test-transf.hpp. @james-d-mitchell, do you think it's worth waiting for a new Catch2 release, or should we fix the issue locally ourselves?

Let's wait and see how quickly your issue with catch is picked up. We don't have to make the changes in this pr, so can wait

New catch version is out, I'll update this later today