Merged
Conversation
12c63e2 to
e3f51d0
Compare
Contributor
Collaborator
|
Looks good, @madebr feel free to rebase and merge when you're ready. |
0561b1e to
7a25b44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely rewrite the cmake build script:
For MSVC, I had to use Visual Studio 2019 (=
windows-2019image) because MPG123 fails to build with Visual Studio 2022.It has something to do with the assembled files, but I don't know exactly as I don't have 2022 installed + there are are no error messages in the log files making me wiser.