cmake: Build vendored libraries statically if SHARED not enabled#246
Closed
smcv wants to merge 6 commits intolibsdl-org:mainfrom
Closed
cmake: Build vendored libraries statically if SHARED not enabled#246smcv wants to merge 6 commits intolibsdl-org:mainfrom
smcv wants to merge 6 commits intolibsdl-org:mainfrom
Conversation
Signed-off-by: Simon McVittie <smcv@collabora.com>
There are enough subtleties with the vendored libraries that it seems worthwhile to test this. Signed-off-by: Simon McVittie <smcv@collabora.com>
We can't run this yet, because the vendored libraries won't be in the dlopen() search path. Signed-off-by: Simon McVittie <smcv@collabora.com>
If we're building vendored libraries, we'll often want them to be an implementation detail of SDL_image that will not conflict with system libraries (or even with libraries vendored by a different dependency), which might be a different version. Signed-off-by: Simon McVittie <smcv@collabora.com>
As with vendored libraries, if we want to use one setting or the other for one of the dependencies, it's likely that we'll want to do the same for all of the dependencies. Signed-off-by: Simon McVittie <smcv@collabora.com>
If we link the vendored libraries statically, then we should have everything we need to make this test work. Signed-off-by: Simon McVittie <smcv@collabora.com>
This was referenced May 20, 2022
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #245
cmake: Build vendored libraries statically if SHARED not enabled
If we're building vendored libraries, we'll often want them to be an
implementation detail of SDL_image that will not conflict with system
libraries (or even with libraries vendored by a different dependency),
which might be a different version.
cmake: Add a default for whether to use shared linking
As with vendored libraries, if we want to use one setting or the other
for one of the dependencies, it's likely that we'll want to do the same
for all of the dependencies.
workflows: Enable the automated test for CMake builds
If we link the vendored libraries statically, then we should have
everything we need to make this test work.