Merged
Conversation
2b32b1e to
15fdf1e
Compare
Contributor
Author
|
https://github.com/smcv/SDL_image/tree/automated-test-cmake is the workflows glue to exercise this for CMake as well, but it will conflict with #238. I think ideally we perhaps want the CMake test to build SDL_image as a shared library, but build the vendored dependencies as static libraries, since that's what someone who is vendoring the dependencies would probably want to do? But I'm not sure how to achieve that (or even whether it's possible without #238). |
Contributor
|
Don't let my cmake pr block this one. |
This loads and saves various supported formats, and asserts that the same pixels (or close enough) end up in the output files. For a distribution that knows it intends to support particular formats, if an environment variable like SVG_IMAGE_TEST_REQUIRE_LOAD_JPG or SVG_IMAGE_TEST_REQUIRE_SAVE_JPG is set, the test will fail if the given format is not available. Signed-off-by: Simon McVittie <smcv@debian.org>
I haven't set it up for CMake yet (although it does work) because that would conflict pretty badly with libsdl-org#238. Signed-off-by: Simon McVittie <smcv@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple automated test
This loads and saves various supported formats, and asserts that the
same pixels (or close enough) end up in the output files.
For a distribution that knows it intends to support particular formats,
if an environment variable like SVG_IMAGE_TEST_REQUIRE_LOAD_JPG or
SVG_IMAGE_TEST_REQUIRE_SAVE_JPG is set, the test will fail if the given
format is not available.
workflows: Run the new automated test for Autotools
I haven't set it up for CMake yet (although it does work) because that
would conflict pretty badly with Improve CMake build system #238.
The idea is that in Debian, I would set (for example)
SVG_IMAGE_TEST_REQUIRE_LOAD_JPG=1andSVG_IMAGE_TEST_REQUIRE_SAVE_JPG=1, because I know that for the build in Debian, JPEG should always be supported, even if for a generic upstream build we can't guarantee that JPEG support will be enabled.