wayland: Support wp-fractional-scale-v1 protocol#5906
wayland: Support wp-fractional-scale-v1 protocol#5906flibitijibibo merged 1 commit intolibsdl-org:mainfrom
Conversation
0808a09 to
20e5c1b
Compare
|
Going to CC @Kontrabant on this one, since I didn't do very much with fractional scaling. Separate from that this looks fine, so whatever the protocols group locks in I'm sure we'll be able to handle it. |
|
Looks good at first glance to me as well. This protocol has been wanted for a while by a lot of people, so hopefully it will be finalized sooner rather than later. |
|
Link to upstream wayland discussions: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/143 |
|
Marked this as 3.0, but if by some chance the protocol gets merged before tag this should be a really safe patch to roll in. |
ba9d765 to
22ba8be
Compare
|
The protocol was approved this morning, so marking this as ready for review. @davidedmundson: Should we merge this after the protocol is merged or after the version is tagged? Do we expect any changes to be made in between those milestones? |
I forgot to post that I finally did some more extensive testing. I have one tiny issue with fullscreen to follow up on where the older path and this conflict in one specific chain. I'll sort it soon. @davidedmundson: Should we merge this after the protocol is merged or after the version is tagged? Do we expect any changes to be made in between those milestones? It's extremely unlikely to change, but if SDL got released with this and then there was a binary incompatiable modification to the protocol before wayland-protocols release the ramifications would be huge. For that reason I would err on the side of waiting. |
|
Plus, it's going to take a little while for compositors to roll out new stable versions with support for it and the next SDL release is a way off, so there's no real reason to rush it through. They seem to tag new releases pretty quickly when a new protocol is approved anyways. |
Kontrabant
left a comment
There was a problem hiding this comment.
Little fix due to a change since the first version of this patch, but otherwise still LGTM.
d3affff to
0f6dbf4
Compare
flibitijibibo
left a comment
There was a problem hiding this comment.
Latest lgtm. Once the final xml is tagged in a release we should be able to merge this into both SDL3 and SDL2!
|
Protocol got merged this morning! @davidedmundson, if you have time: Definitely make an updated commit with the final commit/protocol text, and as soon as the tag is out I should be able to merge (assuming nothing changes between now and tag). |
|
wayland-protocols 1.31 is now tagged and officially released, so everything is ready. |
|
🎉 @davidedmundson, once the commit message and protocol text are updated I'll merge this in! |
The new protocol adds support for more native communication of fractional scaling. Everything in the wayland backend already existed only our fractional scale was calculated implicitly through a combination of output size guesswork for fullscreen windows. This new protocol makes that explicit, providing a more robust solution and a solution for non-fullscreen surfaces. The fallback code is still left in place for now whilst compositors gain support.
0f6dbf4 to
0b91e5a
Compare
|
I filed a bug on the existing issue I found: #6707 but as I said it's pre-existing. I'll try and find time to fix it if no-one beats me to it. |
A pending protocol adds support for more native communication of
fractional scaling.
Everything in the wayland backend already existed only the fractional
scale was calculated implicitly through a combination of output size
guesswork.
The new protocol makes that explicit. I have left the old code in place
for now.
draft because:
approval here
Description
Existing Issue(s)