Skip to content

Add mapping for Dreamcast Controller USB#12039

Merged
slouken merged 3 commits intolibsdl-org:mainfrom
kosekmi:add-dreamcast-controller-usb-mapping
Feb 8, 2025
Merged

Add mapping for Dreamcast Controller USB#12039
slouken merged 3 commits intolibsdl-org:mainfrom
kosekmi:add-dreamcast-controller-usb-mapping

Conversation

@kosekmi
Copy link
Contributor

@kosekmi kosekmi commented Jan 21, 2025

This PR adds mappings for Dreamcast Controller USB

Description

MacOS and Windows mappings for Dreamcast Controller USB were added. Linux bindings are OK by default, so no addition here.

Existing Issue(s)

-None-

@Tails86
Copy link

Tails86 commented Jan 26, 2025

I believe that the crc should be removed from these values. Checking against the VID and PID should be enough to match this controller. These IDs have been formally reserved just for this device at pidcodes.github.com

@kosekmi
Copy link
Contributor Author

kosekmi commented Jan 27, 2025

I believe that the crc should be removed from these values. Checking against the VID and PID should be enough to match this controller. These IDs have been formally reserved just for this device at pidcodes.github.com

Thanks, done!

@kosekmi
Copy link
Contributor Author

kosekmi commented Feb 8, 2025

Any chance this can be merged before the next release?

@slouken slouken merged commit 864bb65 into libsdl-org:main Feb 8, 2025
2 checks passed
@slouken
Copy link
Collaborator

slouken commented Feb 8, 2025

Merged, thanks!

@kosekmi
Copy link
Contributor Author

kosekmi commented Feb 8, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants