Skip to content

Conversation

@dbaarda
Copy link
Member

@dbaarda dbaarda commented Aug 12, 2021

This does minor tidys to the rdiff integration test scripts including;

  1. Use consistent *.test naming for all test scripts.
  2. Use consistent #!/bin/sh -e execution arguments on all test scripts.
  3. Use bash -e when executing scripts on windows for consistency with other platforms.

This makes this test consistent with the other integration test scripts.
This makes the output much less noisy and consistent with the other tests.
This makes the test fail on the first error and is consistent with all the
other intergration test scripts.
This makes the bash cmdline arguments consistent between running on Windows
and on other platforms using the `#!/bin/sh -e`.
For some reason this file that exists as src/isprefix.h was duplicated in the
tests directory.
Putting the quotes around it makes it try to execute a command called "bash
-e" instead of seeing the `-e` as another argument.
@dbaarda dbaarda merged commit bf3e86b into librsync:master Aug 12, 2021
@dbaarda dbaarda deleted the dev/tests1 branch August 12, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant