Skip to content

cmake: fix warning for later CMake versions #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbaarda merged 1 commit into from
Aug 9, 2021
Merged

cmake: fix warning for later CMake versions #221

dbaarda merged 1 commit into from
Aug 9, 2021

Conversation

@rizsotto
Copy link
Contributor

@rizsotto rizsotto commented Aug 8, 2021

When building this project with CMake (version 3.20.5), I got the following error message:

-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.11") 
-- ZLIB_INCLUDE_DIRS  = /usr/include
-- ZLIB_LIBRARIES = /usr/lib64/libz.so
CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (LIBB2) does
  not match the name of the calling package (libb2).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/Findlibb2.cmake:16 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:183 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found LIBB2: /usr/lib64/libb2.so  
-- LIBB2_INCLUDE_DIRS  = /usr/include
-- LIBB2_LIBRARIES = /usr/lib64/libb2.so

To fix it, I've just followed the error message instruction and renamed the cmake/Findlibb2.cmake to cmake/FindLIBB2.cmake. (Plus, I've converted the CMake commands to lowercase to match with the rest of the project.)

@rizsotto rizsotto mentioned this pull request Aug 8, 2021
Closed
@dbaarda dbaarda merged commit 8a90216 into librsync:master Aug 9, 2021
@rizsotto rizsotto deleted the cmakefix branch August 9, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rizsotto @dbaarda