cmake/FindPOPT.cmake: Add PkgConfig support #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PkgConfig support to retrieve popt dependencies otherwise static build can fail if popt has been linked with iconv: [100%] Linking C executable rdiff /home/buildroot/autobuild/instance-2/output-1/per-package/librsync/host/opt/ext-toolchain/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/8.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/instance-2/output-1/per-package/librsync/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/libpopt.a(poptint.o): in function `POPT_fprintf': poptint.c:(.text+0x34c): undefined reference to `libiconv_open Fixes: - http://autobuild.buildroot.org/results/896e8e3efbedad90d66ae8c4e1e50f16206cab49 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
It's possible for find_package() to fail, and thus pkg_search_module() will not be available. Also FIND_PACKAGE_HANDLE_STANDARD_ARGS() should only be needed when PkgConfig didn't work.
Member
|
Thanks for this... it seems sad that every project needs their own version of this, and searching around it seems like they are all different and probably broken in different ways. I fixed it a tiny bit more for the case where find_package() fails. |
This was referenced May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PkgConfig support to retrieve popt dependencies otherwise static
build can fail if popt has been linked with iconv:
Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com