fix compilation with MS Visual Studio ad ignore build files #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I did some digging and it seems "compound statement expressions" are a gcc extension that is not part of the c99 standard. So this was my bad, and thanks for fixing it. I'm going to merge now. |
Contributor
Author
|
That was quick! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Visual Studio C++ compiler seems not to like the current implementation of the
_KEY_HASHmacro. This pull request is aimed to restore compatibility with Microsoft Visual Studio 2019.In addition, some wildcards are added to
.gitignoretargeting output files from CMake and from the build.