Add cmake BUILD_SHARED_LIBS option for static library support. #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUILD_SHARED_LIBS defaults to ON, and can be set to OFF using `ccmake .` to build librsync as a static library.
Use `addons: homebrew:` to install popt on osx instead of manual `before_install:` commands. Remove obsolete `sudo:` settings. Use `os: linux` instead of `dist: xenial` to always use the default linux distribution. Make each entry include `os:` and `compiler:` entries first. Add an entry that tests compiling librsync as a static library.
It seems popt was not correctly installed without this.
Member
Author
|
I've also updated the .travis.yml test builds to use more updated conventions/settings and added a test for static builds. |
Member
Author
|
This is related to issue #154 but I'm not sure that it fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILD_SHARED_LIBS defaults to ON, and can be set to OFF using
ccmake .tobuild librsync as a static library.