Avoid check_c_source_runs() when cross compiling #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross compiling we cannot check for printf "%zu" size_t formating support - instead assume it.
Member
|
I'm not sure if there is a better way to do this than just assume it works for cross-compiling, but I'll accept it as better than what we currently have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using check_c_source_runs() causes the build to fail when cross compiling. In that case we cannot check for printf "%zu" size_t formating support by executing a binary - instead assume it.
This should be safe as AFAIK only MS Visual Studio versions prior to VS2013 doesn't support it, and it's unlikely that someone should be using an old Visual Studio to cross compile librsync.