Fix #33 rs_job_iter needs calling twice with eof=1. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the tube is already "caught up" this will short-circuit it's evaluation better.
Remove rs_job_s_complete() state function and instead use NULL to indicate when the job has completed. Change rs_job_complete() to require the tube is empty when the job is done and never return RS_BLOCKED. Added asserts to check that this precondition is met, and that the result is a terminal value. Added precondition asserts to rs_job_iter() to check its arguments. Refactored rs_job_work() to be more efficient and continue iterating after the job is done until the tube is empty before calling rs_job_complete().
This ensures that it is completely optimized away when debugging is turned off, and more clearly indicates where in the code the job was invalid when the asserts fail. This also required changing rs_job_tag to a #define RS_JOB_TAG.
Member
Author
|
This is another small bug fix. Not much point in waiting for it, I'm going to merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #33 and tidies up and optimizes the rs_job_iter() code. It removes code checking for programming errors and replaces them with more extensive precondition asserts.
I also slightly cleaned and optimized rs_tube_catchup() when there is nothing to catchup.
It also includes changing rs_job_check() from a function to a #define so it gets completely optimized away when debugging is turned off and more clearly indicates where the job was bad when asserts fail.