v2.3.3 tests are failing only on s390x #248
Description
While building librsync v2.3.3 for Fedora Rawhide (I'm the package maintainer), I had to notice that some tests are failing on s390x only. However, the tests of v2.3.2 are still working fine when rebuilding the old version again.
/usr/bin/ctest -C Debug
Test project /builddir/build/BUILD/librsync-2.3.3/redhat-linux-build
Start 1: isprefix_test
1/15 Test #1: isprefix_test .................... Passed 0.00 sec
Start 2: netint_test
2/15 Test #2: netint_test ...................... Passed 0.00 sec
Start 3: rollsum_test
3/15 Test #3: rollsum_test ..................... Passed 0.00 sec
Start 4: rabinkarp_test
4/15 Test #4: rabinkarp_test ................... Passed 0.00 sec
Start 5: hashtable_test
5/15 Test #5: hashtable_test ................... Passed 0.00 sec
Start 6: checksum_test
6/15 Test #6: checksum_test ....................Subprocess aborted***Exception: 0.13 sec
Start 7: sumset_test
7/15 Test #7: sumset_test ......................Subprocess aborted***Exception: 0.05 sec
Start 8: rdiff_bad_option
8/15 Test #8: rdiff_bad_option ................. Passed 0.00 sec
Start 9: Help
9/15 Test #9: Help ............................. Passed 0.01 sec
Start 10: Mutate
10/15 Test #10: Mutate ........................... Passed 1.08 sec
Start 11: Signature
11/15 Test #11: Signature ........................***Failed 0.01 sec
Start 12: Sources
12/15 Test #12: Sources .......................... Passed 1.11 sec
Start 13: Triple
13/15 Test #13: Triple ........................... Passed 1.93 sec
Start 14: Delta
14/15 Test #14: Delta ............................ Passed 0.05 sec
Start 15: Changes
15/15 Test #15: Changes .......................... Passed 0.97 sec
80% tests passed, 3 tests failed out of 15
Total Test time (real) = 5.34 sec
The following tests FAILED:
6 - checksum_test (Subprocess aborted)
7 - sumset_test (Subprocess aborted)
11 - Signature (Failed)
Errors while running CTest
Output from these tests are in: /builddir/build/BUILD/librsync-2.3.3/redhat-linux-build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
+ cat redhat-linux-build/Testing/Temporary/LastTest.log
[…]
----------------------------------------------------------
6/15 Testing: checksum_test
6/15 Test: checksum_test
Command: "/builddir/build/BUILD/librsync-2.3.3/redhat-linux-build/checksum_test"
Directory: /builddir/build/BUILD/librsync-2.3.3/redhat-linux-build
"checksum_test" start time: Feb 18 02:03 UTC
Output:
----------------------------------------------------------
checksum_test: /builddir/build/BUILD/librsync-2.3.3/tests/checksum_test.c:154: main: Assertion `!memcmp(sum, md4, RS_MD4_SUM_LENGTH)' failed.
<end of output>
Test time = 0.13 sec
----------------------------------------------------------
Test Failed.
"checksum_test" end time: Feb 18 02:03 UTC
"checksum_test" time elapsed: 00:00:00
----------------------------------------------------------
7/15 Testing: sumset_test
7/15 Test: sumset_test
Command: "/builddir/build/BUILD/librsync-2.3.3/redhat-linux-build/sumset_test"
Directory: /builddir/build/BUILD/librsync-2.3.3/redhat-linux-build
"sumset_test" start time: Feb 18 02:03 UTC
Output:
----------------------------------------------------------
librsync: ERROR: (rs_sig_args) invalid magic 0x1
librsync: ERROR: (rs_sig_args) invalid strong_len=33 for magic=0x72730147
librsync: ERROR: (rs_sig_args) invalid strong_len=33 for magic=0x72730137
librsync: ERROR: (rs_sig_args) invalid strong_len=17 for magic=0x72730146
librsync: ERROR: (rs_sig_args) invalid strong_len=17 for magic=0x72730136
librsync: ERROR: (rs_sig_args) invalid magic 0x1
librsync: ERROR: (rs_sig_args) invalid strong_len=17 for magic=0x72730136
librsync: ERROR: (rs_sig_args) invalid strong_len=17 for magic=0x72730146
librsync: ERROR: (rs_sig_args) invalid strong_len=33 for magic=0x72730137
librsync: ERROR: (rs_sig_args) invalid strong_len=33 for magic=0x72730147
sumset_test: /builddir/build/BUILD/librsync-2.3.3/tests/sumset_test.c:243: main: Assertion `memcmp(&strong, "\x29\x8a\x05\xbc\x50\x6e", 6) == 0' failed.
<end of output>
Test time = 0.05 sec
----------------------------------------------------------
Test Failed.
"sumset_test" end time: Feb 18 02:03 UTC
"sumset_test" time elapsed: 00:00:00
----------------------------------------------------------
[…]
----------------------------------------------------------
11/15 Testing: Signature
11/15 Test: Signature
Command: "/builddir/build/BUILD/librsync-2.3.3/tests/signature.test" "/builddir/build/BUILD/librsync-2.3.3/redhat-linux-build/rdiff"
Directory: /builddir/build/BUILD/librsync-2.3.3/tests
"Signature" start time: Feb 18 02:03 UTC
Output:
----------------------------------------------------------
RDIFF /builddir/build/BUILD/librsync-2.3.3/redhat-linux-build/rdiff
/builddir/build/BUILD/librsync-2.3.3/redhat-linux-build/rdiff -Rrollsum -Hmd4 -S0 -I0 -f signature ./signature.input/01.input /tmp/librsynctest_k6uOtM5e/signature
./signature.input/01-Rrollsum-Hmd4-S0.sig /tmp/librsynctest_k6uOtM5e/signature differ: char 17, line 1
: comparison failed from command:
<end of output>
Test time = 0.01 sec
----------------------------------------------------------
Test Failed.
"Signature" end time: Feb 18 02:03 UTC
"Signature" time elapsed: 00:00:00
----------------------------------------------------------
[…]
I'm happy to submit test builds or similar to the build system; if s390x shell access (however in a separate environment, not the actual build system itself) is needed for debugging, please let me know.