config.lib.sh: use brcm vg/egl/glesv2 packages on RPI#5351
Merged
inactive123 merged 1 commit intolibretro:masterfrom Aug 20, 2017
Merged
config.lib.sh: use brcm vg/egl/glesv2 packages on RPI#5351inactive123 merged 1 commit intolibretro:masterfrom
inactive123 merged 1 commit intolibretro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge yet, please - needs discussion.
Unfortunately, my previous commit was not sufficient to ensure the proper Broadcom libraries were being linked - it was adding -lEGL and -lbrcmEGL, -lGLESv2 and -lbrcmGLESv2, and I forgot that OpenVG was also renamed.
The commit would fix the issue, but for some reason, libraspberrypi0 and libraspberrypi-dev omits the pkgconfig configuration files here: https://github.com/raspberrypi/firmware/tree/master/opt/vc/lib/pkgconfig
If I copy the brcm*.pc to /usr/lib/pkgconfig/*, then this commit will work as intended and will use the proper libs for linking.
Suggestions? I can raise the issue upstream in order for future packages to include the necessary files, or maybe I'm overlooking another solution?