Skip to content

Cherry-pick: revert "Use server-list.json in classic frontend by default"#776

Merged
sstidl merged 2 commits intomasterfrom
copilot/cherry-pick-fd76790
Apr 12, 2026
Merged

Cherry-pick: revert "Use server-list.json in classic frontend by default"#776
sstidl merged 2 commits intomasterfrom
copilot/cherry-pick-fd76790

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 12, 2026

Cherry-picks fd76790 into master, reverting the automatic server-list.json fallback that was added to the classic frontend.

Changes

  • index-classic.html: Restores original initServers() logic — standalone installations go straight to the test UI; multi-server installations either fetch from an explicit URL string or use the hardcoded array. Removes the intermediate "try server-list.json, fall back to standalone" path that was introduced.

This reverts commit fdb1681.

Co-authored-by: sstidl <12804296+sstidl@users.noreply.github.com>
@sstidl sstidl marked this pull request as ready for review April 12, 2026 10:47
@sstidl sstidl merged commit 6693c7e into master Apr 12, 2026
@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Revert server-list.json fallback in classic frontend

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Revert automatic server-list.json fallback in classic frontend
• Restore original standalone vs multi-server initialization logic
• Bump version to v6.0.1
Diagram
flowchart LR
  A["initServers function"] --> B{SPEEDTEST_SERVERS empty?}
  B -->|Yes| C["Show standalone UI"]
  B -->|No| D{Is string URL?}
  D -->|Yes| E["Load from URL"]
  D -->|No| F["Use hardcoded list"]
  E --> G["Run server selection"]
  F --> G
Loading

Grey Divider

File Changes

1. speedtest.js ⚙️ Configuration changes +1/-1

Version bump to v6.0.1

• Update version string from v6.0.0pre1 to v6.0.1

speedtest.js


2. index-classic.html 🐞 Bug fix +41/-47

Restore original server initialization logic

• Remove automatic server-list.json fallback for standalone installations
• Restore original logic: standalone mode skips server selection entirely
• Multi-server mode handles explicit URL strings or hardcoded arrays
• Simplify initServers function by removing intermediate loading state

index-classic.html


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

qodo-free-for-open-source-projects bot commented Apr 12, 2026

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)   🎨 UX Issues (0)
🐞\ ⚙ Maintainability (1)

Grey Divider


Remediation recommended

1. Version metadata mismatch 🐞
Description
speedtest.js now logs version v6.0.1 at runtime, but package.json still declares version 6.0.0,
which can confuse users and tooling relying on package metadata.
Code

speedtest.js[R51-53]

  console.log(
-    "LibreSpeed by Federico Dossena v6.0.0pre1 - https://github.com/librespeed/speedtest"
+    "LibreSpeed by Federico Dossena v6.0.1 - https://github.com/librespeed/speedtest"
  );
Evidence
The PR changes the logged version string to v6.0.1, while the package manifest still reports 6.0.0
in the checked-out PR branch code, leaving inconsistent version reporting.

speedtest.js[46-54]
package.json[1-6]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`speedtest.js` prints `v6.0.1` at runtime, but `package.json` still reports version `6.0.0`, creating inconsistent version reporting.

### Issue Context
This PR updates only the runtime banner string; the repo’s package metadata remains unchanged.

### Fix Focus Areas
- package.json[1-6]
- speedtest.js[46-54]

### Suggested fix
Either:
1) Bump `package.json.version` to `6.0.1`, or
2) Revert/adjust the `console.log` banner to match the intended package version.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants