Support -M <mapfile> option for Solaris/illumos ld#324
Support -M <mapfile> option for Solaris/illumos ld#324janbrummer merged 1 commit intolibproxy:mainfrom
Conversation
|
Thanks for your PR, love it. We just had a quick discuison about this PR and we would like to see a solaris host_system check to decided which way to go. Could you please rewrite it? |
|
Could you please check whether #326 helps a bit? |
It doesn't change anything, since our ld doesn't understand |
Sure, I can wrap it with a host_system check. |
Use empty test mapfile with no symbols for link tests.
|
Simplified the test and wrapped it in a |
|
Fine for me. Any objections @DimStar77 ? |
|
Ok, lets fly then :) Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 69.30% 69.37% +0.06%
==========================================
Files 18 18
Lines 935 937 +2
Branches 265 267 +2
==========================================
+ Hits 648 650 +2
Misses 174 174
Partials 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The mapfile format for Solaris/illumos ld is the same one used by GNU ld, but the linker option is
-M <mapfile>instead of--version-script,<mapfile>.-Blocalor-Beliminateis also needed to deal with symbols not specified in the mapfile. Use an empty test mapfile with no symbols for link tests.