Skip to content

kde: Support Proxy Config Script value without scheme#319

Merged
janbrummer merged 1 commit intomainfrom
fix-kde-proxy-config-missing-scheme
Jan 15, 2025
Merged

kde: Support Proxy Config Script value without scheme#319
janbrummer merged 1 commit intomainfrom
fix-kde-proxy-config-missing-scheme

Conversation

@janbrummer
Copy link
Copy Markdown
Contributor

KDE allows users to set local files without file:// scheme. Handle this case and set file:// prefix.

KDE allows users to set local files without file:// scheme. Handle this
case and set file:// prefix.

Fixes: #318
@janbrummer janbrummer force-pushed the fix-kde-proxy-config-missing-scheme branch from baabb52 to 6fe03fb Compare January 15, 2025 14:11
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.30%. Comparing base (77e2a2b) to head (6fe03fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/backend/plugins/config-kde/config-kde.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   68.99%   69.30%   +0.30%     
==========================================
  Files          18       18              
  Lines         887      935      +48     
  Branches      263      265       +2     
==========================================
+ Hits          612      648      +36     
- Misses        166      174       +8     
- Partials      109      113       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janbrummer janbrummer merged commit de9c069 into main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant