Merged
Conversation
a65a225 to
ae8104f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 72.73% 69.16% -3.57%
==========================================
Files 16 18 +2
Lines 851 879 +28
Branches 242 259 +17
==========================================
- Hits 619 608 -11
- Misses 137 164 +27
- Partials 95 107 +12 ☔ View full report in Codecov by Sentry. |
Currently CI fails due to gi-docgen error: FAILED: docs/libproxy-1.0 /opt/homebrew/bin/gi-docgen generate --quiet --add-include-path=/Users/runner/work/libproxy/libproxy/docs/src --config=docs/px.toml --output-dir=docs/libproxy-1.0 --no-namespace-dir --content-dir=/Users/runner/work/libproxy/libproxy/docs src/libproxy/Libproxy-1.0.gir /opt/homebrew/Cellar/gi-docgen/2023.3/libexec/lib/python3.12/site-packages/typogrify/filters.py:46: SyntaxWarning: invalid escape sequence '\s' tag = match.group(1) if match.group(1) != '' else '[^\s.#<>]+' /opt/homebrew/Cellar/gi-docgen/2023.3/libexec/lib/python3.12/site-packages/typogrify/filters.py:140: SyntaxWarning: invalid escape sequence '\w' tag_pattern = '</?\w+((\s+\w+(\s*=\s*(?:".*?"|\'.*?\'|[^\'">\s]+))?)+\s*|\s*)/?>' /opt/homebrew/Cellar/gi-docgen/2023.3/libexec/lib/python3.12/site-packages/typogrify/packages/titlecase/__init__.py:18: SyntaxWarning: invalid escape sequence '\.' SMALL = 'a|an|and|as|at|but|by|en|for|if|in|of|on|or|the|to|v\.?|via|vs\.?' ERROR: Could not find GIR dependency in the search paths: Gio-2.0 ninja: build stopped: subcommand failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.