meson: Don't build OSX plugin on iOS#284
Merged
janbrummer merged 2 commits intolibproxy:mainfrom Apr 2, 2024
Merged
Conversation
amyspark
suggested changes
Mar 8, 2024
7a21357 to
b1d52fa
Compare
Fails to build with: ../src/backend/plugins/config-osx/config-osx.c:284:29: error: 'SCDynamicStoreCopyProxies' is unavailable: not available on iOS Which is true, it's only available on macOS 10.1+ https://developer.apple.com/documentation/systemconfiguration/1517088-scdynamicstorecopyproxies
b1d52fa to
0ba2b8a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 72.73% 72.73%
=======================================
Files 16 16
Lines 851 851
Branches 242 242
=======================================
Hits 619 619
Misses 137 137
Partials 95 95 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fails to build with:
../src/backend/plugins/config-osx/config-osx.c:284:29: error: 'SCDynamicStoreCopyProxies' is unavailable: not available on iOSWhich is true, it's only available on macOS 10.1+
https://developer.apple.com/documentation/systemconfiguration/1517088-scdynamicstorecopyproxies