Fix broken WPAD proxy resolution#271
Merged
janbrummer merged 1 commit intolibproxy:mainfrom Feb 9, 2024
Merged
Conversation
When discovering a PAC URL through WPAD, libproxy would download the file, but never call set_pac() on the PAC Runner interface, unlike in the case with an explicitly configured PAC URL. This would cause the PAC Runner implementation to just return an empty string from run()
Contributor
Author
|
It looks like this may be a regression stemming from #244 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
- Coverage 73.19% 72.67% -0.52%
==========================================
Files 16 16
Lines 843 849 +6
Branches 238 241 +3
==========================================
Hits 617 617
- Misses 131 137 +6
Partials 95 95 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When discovering a PAC URL through WPAD, libproxy would download the file, but never call
set_pac()on the PAC Runner interface, unlike in the case with an explicitly configured PAC URL. This would cause the PAC Runner implementation to just return an empty string fromrun()