Improve handling of Windows proxy settings:#264
Merged
janbrummer merged 1 commit intolibproxy:mainfrom Jan 8, 2024
Merged
Conversation
- Handle proxy URLs being provided with a scheme - Don't assume that target URL scheme == proxy scheme - Use proxy provided without a scheme specifier for all target URL schemes - Free memory allocated for hash table keys and values
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 73.15% 73.15%
=======================================
Files 16 16
Lines 842 842
Branches 238 238
=======================================
Hits 616 616
Misses 131 131
Partials 95 95 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From testing, this is much more in line with how Edge and the .NET System.Net.WebProxy works