pnet_macros: Fix handle_vec_primitive for multi byte primitives#596
Merged
mrmonday merged 1 commit intolibpnet:masterfrom Jan 27, 2023
Merged
pnet_macros: Fix handle_vec_primitive for multi byte primitives#596mrmonday merged 1 commit intolibpnet:masterfrom
mrmonday merged 1 commit intolibpnet:masterfrom
Conversation
Contributor
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
get_*()will panic for primitives larger than 1 byte with an array out of bounds, e.g.u32bebecause it will try to push forvec.capacity()times which is set to the number of bytes in the vec. The correct times to push is the number of elements, which is the number of bytes divided by the size.