Merged
Conversation
Instead of returning the next received arp packet, wait for receiving arp packet from the target.
|
Your fix made the example run as expected. Got almost a headache wondering why the mac of my NIC was returned and not of the remote host. This should be merged into the main branch ASAP. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IIUC, the goal of this code is to look up MAC address matching
target_ip, by receiving ARP packet from the target host sends.If so, catching subsequent packet won't work because the very next received packet is the ARP request just sent by the function itself. (at least on my macbook)
To make this work, IMO, lookup every packets while reply packet found.