Skip to content

Misc fixes#551

Merged
mrmonday merged 1 commit intolibpnet:masterfrom
mrmonday:expect-build
Apr 11, 2022
Merged

Misc fixes#551
mrmonday merged 1 commit intolibpnet:masterfrom
mrmonday:expect-build

Conversation

@mrmonday
Copy link
Copy Markdown
Contributor

@mrmonday mrmonday commented Apr 11, 2022

  • Ensure build.sh error on unsupported platforms
  • Replace .unwrap() with .expect() in test suite

@mrmonday
Misc fixes
9651626 
 * Ensure build.sh error on unsupported platforms
 * Replace `.unwrap()` with `.expect()` in test suite
@mrmonday mrmonday merged commit a91a205 into libpnet:master Apr 11, 2022
@mrmonday mrmonday deleted the expect-build branch April 11, 2022 15:39
@teutat3s
Copy link
Copy Markdown
Contributor

teutat3s commented Apr 11, 2022 

make test
...
+ echo 'Unsupported testing platform'
Unsupported testing platform

echo $?
0

-> exit 1 missing in run_test()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrmonday @teutat3s