Skip to content

fix: add tls support for python#798

Merged
seetadev merged 2 commits intolibp2p:masterfrom
acul71:fix/python-v0.x-tls-certificates-no-extentions
Jan 26, 2026
Merged

fix: add tls support for python#798
seetadev merged 2 commits intolibp2p:masterfrom
acul71:fix/python-v0.x-tls-certificates-no-extentions

Conversation

@acul71
Copy link
Copy Markdown
Contributor

@acul71 acul71 commented Jan 25, 2026

Adding python TLS support
Was failing before because of certificate extensions (not in specs)

@acul71
Copy link
Copy Markdown
Contributor Author

acul71 commented Jan 25, 2026

@seetadev @dhuseby
This can be merged is solves the rust - python tls test failure.
Details here : libp2p/py-libp2p#1151

@acul71
Copy link
Copy Markdown
Contributor Author

acul71 commented Jan 26, 2026

@seetadev Ready now

@seetadev seetadev merged commit 2d2165b into libp2p:master Jan 26, 2026
2 checks passed
@seetadev
Copy link
Copy Markdown
Collaborator

Thanks a lot for pushing this through, @acul71 — great work on tracking this down and fixing it cleanly.

Resolving the TLS failure caused by certificate extensions (and aligning with the spec) unblocks an important class of interop tests, and it’s great to see the rust ↔ python TLS mismatch addressed directly. The additional handling around the exception also makes the fix much more robust.

Appreciate the clear context and follow-up references as well — that made review and merge straightforward. This is a solid improvement for Python support in libp2p.

Looking forward to more contributions like this — thanks again for the effort 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants