-
Notifications
You must be signed in to change notification settings - Fork 292
Closed
Description
Taking a look at these two parts of the specs:
-
WebRTC Direct says:
Lines 166 to 167 in d2106f4
1. _A_ and _B_ open a WebRTC data channel with `id: 0` and `negotiated: true` ([`pc.createDataChannel("", {negotiated: true, id: -
WebRTC README says:
Lines 134 to 135 in d2106f4
Pion, ...). In other words libp2p WebRTC implementations MUST NOT change the default value `negotiated: false` when creating a `RTCDataChannel` via
These two seem to conflict when setting negotiated.
We definitely are setting the negotiated to true during the Noise handshake, so something might be missing from the explanation, like an exception if you are doing a Noise handshake?
Perhaps changing the README to add:
unless you are conducting a Noise Handshake, then // <== added
libp2p WebRTC implementations MUST NOT change the default value `negotiated: false`thoughts/clarifications?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels