refactor(relay): use oneshot's to track requested streams#4900
Merged
mergify[bot] merged 2 commits intomasterfrom Nov 28, 2023
Merged
refactor(relay): use oneshot's to track requested streams#4900mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
This was referenced Nov 20, 2023
mxinden
approved these changes
Nov 28, 2023
Member
mxinden
left a comment
There was a problem hiding this comment.
Great! Especially with make_new_reservation and establish_new_circuit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is much cleaner as it allows us to construct a single
Futurethat expresses the entire outbound protocol from stream opening to finish.Notes & open questions
Change checklist