Skip to content

feat(kad): deprecate Config::set_connection_idle_timeout#4675

Merged
mergify[bot] merged 4 commits intolibp2p:masterfrom
leonzchang:feat/kad-deprecate-idle-timeout
Oct 17, 2023
Merged

feat(kad): deprecate Config::set_connection_idle_timeout#4675
mergify[bot] merged 4 commits intolibp2p:masterfrom
leonzchang:feat/kad-deprecate-idle-timeout

Conversation

@leonzchang
Copy link
Copy Markdown
Contributor

@leonzchang leonzchang commented Oct 17, 2023 •
edited by thomaseizinger
Loading

Description

Related: #3844.
Related: #4659.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@leonzchang leonzchang mentioned this pull request Oct 17, 2023
Merged
4 tasks
@leonzchang leonzchang changed the title feat(kad): deprecate Config::set_connection_idle_timeout feat(kad): deprecate Config::set_connection_idle_timeout Oct 17, 2023
@leonzchang
Copy link
Copy Markdown
Contributor Author

leonzchang commented Oct 17, 2023

rust-libp2p/protocols/kad/src/behaviour.rs

Lines 1896 to 1913 in b00a8b9

fn on_connection_established(
&mut self,
ConnectionEstablished {
peer_id,
failed_addresses,
other_established,
..
}: ConnectionEstablished,
) {
for addr in failed_addresses {
self.address_failed(peer_id, addr);
}
// Peer's first connection.
if other_established == 0 {
self.connected_peers.insert(peer_id);
}
}

This may need to be changed when the #4659 (comment) is confirmed.

@leonzchang leonzchang marked this pull request as ready for review October 17, 2023 07:30
thomaseizinger
thomaseizinger approved these changes Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the help!

@thomaseizinger thomaseizinger mentioned this pull request Oct 17, 2023
Closed
@mergify mergify bot merged commit 411824a into libp2p:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees

No one assigned

Labels

send-it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leonzchang @thomaseizinger