Skip to content

fix(swarm): log local peer ID correctly#4671

Merged
mergify[bot] merged 4 commits intomasterfrom
chore/move-log
Oct 25, 2023
Merged

fix(swarm): log local peer ID correctly#4671
mergify[bot] merged 4 commits intomasterfrom
chore/move-log

Conversation

@thomaseizinger
Copy link
Copy Markdown
Contributor

@thomaseizinger thomaseizinger commented Oct 16, 2023

Description

This was an oversight in #4120, where we changed the creation of Swarm. Thus, all usages of the new SwarmBuilder did not actually hit this log line.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. and removed internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. labels Oct 25, 2023
@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Oct 25, 2023
@mergify mergify bot merged commit 85e6105 into master Oct 25, 2023
@mergify mergify bot deleted the chore/move-log branch October 25, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees

No one assigned

Labels

send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thomaseizinger