Reorg tests, add contributing page, drop bumpversion for bump-my-version#454
Merged
pacrob merged 4 commits intolibp2p:mainfrom Apr 20, 2024
Merged
Reorg tests, add contributing page, drop bumpversion for bump-my-version#454pacrob merged 4 commits intolibp2p:mainfrom
pacrob merged 4 commits intolibp2p:mainfrom
Conversation
774a2c5 to
b987b0c
Compare
…ump-my-version and move config to pyproject.toml, fix docs building
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
We don't need 2 top-level tests folders. bumpversion is deprecated. Contributing docs need improvement.
How was it fixed?
Moved
tests_interopinto thetestsfolder and renamed it to justinterop. Adjusted test paths and other references to match. Interop tests are still turned off.Dropped bumpversion for bump-my-version and moved its config to
pyproject.toml.Fleshed out Contributing docs.
To-Do
Cute Animal Picture