Refactored RoutedHost into Injected Router#157
Merged
Conversation
…into router-refactor
…into router-refactor
…into router-refactor
958c9ae to
3b1a3fb
Compare
zixuanzh
suggested changes
Apr 29, 2019
Contributor
zixuanzh
left a comment
There was a problem hiding this comment.
LGTM with some minor changes and print statement fixes
libp2p/__init__.py
Outdated
| peerstore_opt=peerstore_opt) | ||
| peerstore_opt=peerstore_opt, disc_opt=disc_opt) | ||
|
|
||
| swarm_opt.add_router(disc_opt) |
Contributor
There was a problem hiding this comment.
I think we can take out this line as disc_opt should have been passed into Swarm in Swarm construction at line 83.
libp2p/host/basic_host.py
Outdated
| self.peerstore = self.network.peerstore | ||
| def __init__(self, network, router=None): | ||
| self._network = network | ||
| self.peerstore = self._network.peerstore |
Contributor
There was a problem hiding this comment.
let's place this line after line 17 to look cleaner
| async def find_peer(self, peer_id): | ||
| """ | ||
| Find specific Peer | ||
| FindPeer searches for a peer with given peer_id, returns a peer.PeerInfo |
Contributor
There was a problem hiding this comment.
it is returning a KadPeerInfo here from decode_peerinfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #153 (comment), RoutedHost has been refactored into a dependency injection IoC model where we inject a router implementing using kademlia DHT into swarm.