Skip to content
This repository was archived by the owner on Aug 23, 2019. It is now read-only.

fix deps#254

Merged
daviddias merged 2 commits intomasterfrom
feat/pull-mplex
May 12, 2018
Merged

fix deps#254
daviddias merged 2 commits intomasterfrom
feat/pull-mplex

Conversation

@dryajov
Copy link
Copy Markdown
Member

@dryajov dryajov commented May 9, 2018

NOTE: Im using libp2p-mplex as a git dep, so that we can test it on CI. This is temporary and should be changed once libp2p-mplex is released.

@dryajov
Copy link
Copy Markdown
Member Author

dryajov commented May 12, 2018

These PRs are only needed to ensure CI runs correctly with the new implementation. It is not supposed to get merged just yet, it need pull-mplex and libp2p-mplex published first. Please don't change them.

@coveralls
Copy link
Copy Markdown

coveralls commented May 12, 2018

Pull Request Test Coverage Report for Build 841

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.253%

Totals Coverage Status
Change from base Build 837: 0.0%
Covered Lines: 574
Relevant Lines: 610

💛 - Coveralls

const series = require('async/series')
const TCP = require('libp2p-tcp')
const multiplex = require('libp2p-multiplex')
const multiplex = require('libp2p-mplex')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dryajov this was a legit issue that fixes it.

@daviddias daviddias changed the title feat: used pull stream based mplex fix deps May 12, 2018
@daviddias daviddias merged commit 36bc50b into master May 12, 2018
@ghost ghost removed the in progress label May 12, 2018
@daviddias daviddias deleted the feat/pull-mplex branch May 12, 2018 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants