This repository was archived by the owner on Jul 21, 2023. It is now read-only.
fix: find peer and providers options#45
Merged
vasco-santos merged 2 commits intomasterfrom Sep 27, 2018
Merged
Conversation
This was referenced Sep 26, 2018
Contributor
|
Changes look good, not sure why CI is not registering tests. |
Contributor
|
@vasco-santos it looks like the recent jenkins updates look for |
Member
Author
|
Oh thanks! I will add it now |
Member
Author
|
@jacobheun CI is green now. Once you approve this, I can release a new version of the package for you to use on: |
Member
Author
|
done! 🚀 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aiming to allow other future options to
findPeerandfindProviders, I changed themaxTimeoutparam to an objectoptions.In the context of