This repository was archived by the owner on Jul 21, 2023. It is now read-only.
fix: dht get options#40
Merged
vasco-santos merged 1 commit intomasterfrom Sep 20, 2018
Merged
Conversation
1 task
jacobheun
approved these changes
Sep 20, 2018
Contributor
jacobheun
left a comment
There was a problem hiding this comment.
Windows on Jenkins is not having a good day, the changes look good.
Member
Author
|
Thanks for the review @jacobheun ! I will restart the CI to get it green |
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
dht.getanddht.getManymaxTimeoutparameter to anoptionsparameter with themaxTimeoutproperty as discussed here.