This repository was archived by the owner on Jul 21, 2023. It is now read-only.
Conversation
This was referenced Jan 17, 2017
10 tasks
This was referenced Apr 1, 2017
daviddias
reviewed
Apr 4, 2017
| @@ -0,0 +1,13 @@ | |||
| language: node_js | |||
| node_js: | |||
| - 4 | |||
daviddias
reviewed
Apr 4, 2017
|  | ||
|
|
||
| > JavaScript implementation of the DHT for libp2p | ||
| > JavaScript implementation of the Kademlia DHT for libp2p, based on [go-kad-dht](https://github.com/libp2p/go-libp2p-kad-dht). |
Member
There was a problem hiding this comment.
s/go-kad-dht/go-libp2p-kad-dht
Member
|
@dignifiedquire seeing an error in occasionally: |
daviddias
suggested changes
Apr 6, 2017
| * @param {number} [maxTimeout=10000] - how long to wait for the the bootstrap query to run, in milliseconds (10s) | ||
| * @returns {void} | ||
| */ | ||
| bootstrapStart (queries, period, maxTimeout) { |
Member
There was a problem hiding this comment.
This is, in fact, a discovery service that DHT provides and so as any discovery service it needs to be passed into the discovery mechanisms
Member
Member
|
@dignifiedquire can you elaborate on the work behind (and importance of)
|
Member
Author
These are nice to haves to check for specific failure behaviour but not crucial for shipping. |
daviddias
suggested changes
Apr 6, 2017
| @@ -0,0 +1,13 @@ | |||
| language: node_js | |||
| node_js: | |||
| - 4 | |||
|  | ||
|
|
||
| > JavaScript implementation of the DHT for libp2p | ||
| > JavaScript implementation of the Kademlia DHT for libp2p, based on [go-kad-dht](https://github.com/libp2p/go-libp2p-kad-dht). |
| ### npm | ||
|
|
||
| ```sh | ||
| > npm i libp2p-dht |
| ### Use in Node.js | ||
|
|
||
| ```js | ||
| const KadDHT = require('libp2p-dht') |
|
|
||
| ## API | ||
|
|
||
| See https://libp2p.github.io/js-libp2p-dht |
daviddias
approved these changes
Apr 6, 2017
daviddias
suggested changes
Apr 6, 2017
daviddias
approved these changes
Apr 7, 2017
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dragons still live here. So beware of them.
Things left to do
peer:disconnectjs-libp2p#74[external] Add latency recording to peer-book(moved to Add ability to record latency information js-peer-book#34)[external] Add close method to interface-connection(moved to https://github.com/libp2p/js-libp2p-swarm/issues/205)Figure out if go uses lp messages or not, It does, need to implement itdht_test.gofindPeersConnectedToPeer(removing, doesn't work in go and will be implemented at a later point)ext_test.gostartandstop