Conversation
830dd76 to
c931c46
Compare
4 tasks
Closed
jacobheun
reviewed
Nov 29, 2018
src/index.js
Outdated
| datastore: this.datastore | ||
| datastore: this.datastore, | ||
| validators: this._config.dht.validators || {}, | ||
| selectors: this._config.dht.selectors || {} |
Contributor
There was a problem hiding this comment.
Is there any reason these can't just be null, instead of creating an empty object?
Member
Author
There was a problem hiding this comment.
No, I am also doing this in kad-dht, I will change it now! Thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow configurable validators and selectors. Users of
libp2pwithlibp2p-kad-dhtmust be able to set their own validators and selectors.For instance, this is important for
js-ipfsto use/ipns/namespaces in the DHT