Skip to content

test: default to noise in tests#41

Merged
vasco-santos merged 1 commit intomasterfrom
test/default-noise
Jun 26, 2020
Merged

test: default to noise in tests#41
vasco-santos merged 1 commit intomasterfrom
test/default-noise

Conversation

@jacobheun
Copy link
Contributor

This switches the test daemons to default to running noise instead of secio. Basic connection tests for the 3 key types are still being run for both secio and noise.

Ref:
go-libp2p defaulting to Noise libp2p/go-libp2p#972

@jacobheun
Copy link
Contributor Author

We're still using go libp2p 0.8.1 (latest is 0.10.0), we should update this. It would be nice to get CI to just pull go and install instead of fetching the binaries.

@vasco-santos
Copy link
Member

We are block on the go daemon PR libp2p/go-libp2p-daemon#233.

It would be nice to get CI to just pull go and install instead of fetching the binaries.

The main issue for that is that we need the daemon updated and not go-libp2p. Also, support different platforms. I think the ideal solution would be to publish the binaries on a release, in the same way ipfs works

@vasco-santos vasco-santos merged commit 8d9b9d2 into master Jun 26, 2020
@vasco-santos vasco-santos deleted the test/default-noise branch June 26, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants