Conversation
|
@willscott Will review this early-mid net week. Does that work for you ? |
Contributor
Author
👍 |
Contributor
Author
|
@aarshkshah1992 - are you wanting to review this? |
Contributor
Author
|
merging before this gets too stale. the additional test helpers seem fairly low risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor some common testing infrastructure for evaluating yamux and mplex.
Example usage of
FindNetworkLimitis to wrap it in a test, e.g.Tests will be added in
go-libp2p-yamuxandgo-libp2p-mplexwrapping this. example output looks something like:The basic mechanism this harness is implementing is first identifying how much the boundary between CPU-bound and Network-bound limitations of a given testing operation. Then, on the network-bound side of that boundary, increasing parallelism and watching the ratio of how utilized the network link is.
Notes: the output from the wrapped
testing.Benchmarkcalls don't account for threads/processes properly - the reportedns/opandMB/sdoes a racy division on number of spawned threads, as far as i can tell. it ends up not particularly useful, but the overall bytes pushed over the network is bench-marked correctly across parallelism.