This repository was archived by the owner on Sep 6, 2022. It is now read-only.
implement Stringer for network.{Direction,Connectedness,Reachability}.#150
Merged
implement Stringer for network.{Direction,Connectedness,Reachability}.#150
Conversation
Stebalien
approved these changes
May 13, 2020
Member
Stebalien
left a comment
There was a problem hiding this comment.
It would be nice to not panic if we get an unknown reachability type (I'm concerned users may cast to these constants to/from the network).
aarshkshah1992
approved these changes
May 13, 2020
Member
Author
|
@Stebalien makes sense, I'll rejig this. I also felt kinda uncomfortable panicking instead of returning something like: "(unrecognized)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty non-controversial.