fix host can be dialed by autonat public addr, but lost the public addr to announce#983
Merged
willscott merged 2 commits intolibp2p:masterfrom Jul 24, 2020
Conversation
…r by net.InterfaceAddrs()
willscott
reviewed
Jul 23, 2020
Contributor
|
cc @aschmahmann - not sure if this changes the assumptions for 'local addresses' that the downstream kad-dht is expecting, but this seems like a place to percolate up autonat discovered address that had been missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following scenario:
peers deployed on a cloud server, which may provides an elastic ip accessible to the public network, but not have an external network card, so net.InterfaceAddrs() can't get the public ip (call by InterfaceMultiaddrs for get addresses associated with host)
The host can indeed be dialed by autonat public addr, but lost the public addr to announce!