fix: avoid a close deadlock in the natmanager#971
Merged
Conversation
Before, we would: 1. Receive a "listen close" event from an event handler, after the teardown started. 2. Try to add a child process to handle the event. This would block because we were in the teardown. 3. In the teardown, try to unregister the event handler and deadlock I've now: * Removed the teardown. * Switched to a single event loop. Ideally, we'd remove goprocess entirely. But we'd need to refactor natmgr. fixes #933
hsanjuan
approved these changes
Jun 23, 2020
Contributor
hsanjuan
left a comment
There was a problem hiding this comment.
I am too unfamiliar with this code to say this is bug-free, but the pattern looks ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we would:
I've now:
Ideally, we'd remove goprocess entirely. But we'd need to refactor natmgr.
fixes #933