Disable generation of Signed peer record for Mockenets#934
Merged
aarshkshah1992 merged 1 commit intomasterfrom May 19, 2020
Merged
Disable generation of Signed peer record for Mockenets#934aarshkshah1992 merged 1 commit intomasterfrom
aarshkshah1992 merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
#917 is waiting on this. |
Stebalien
approved these changes
May 19, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #929.
Mocknets use Bogus private keys which shouldn't be used for signing records. However, this leads to the peer sending malformed signed peer records which floods up our test logs.
This PR exposes an Option on the Host to disable generation of signed peer records. It also ensures that Identify responses we send ONLY have unsigned addresses.
ONLY Mocknets uses this Option.