Conversation
we have per TLD resolvers and this helps end user to self-service when one of DoH resolvers goes down
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End user applications built with this library have per TLD DoH resolvers (example).
Including the URL of DoH endpoint helps end user to self-service when one of DoH resolvers goes down (example: ipfs/boxo#772)
Demo
Let's assume
https://example.com/dns-queryresponsible for resolving.testTLD is down.Without this PR, user gets confusing error:
With this PR, end user gets meaningful error
HTTP error: "405 Method Not Allowed" [405] from "https://example.com/dns-query"