Skip to content

panic if a negative length is passed to BufferPool.Get#28

Merged
marten-seemann merged 1 commit intomasterfrom
fix-get-with-negative-length
Jul 1, 2022
Merged

panic if a negative length is passed to BufferPool.Get#28
marten-seemann merged 1 commit intomasterfrom
fix-get-with-negative-length

Conversation

@marten-seemann
Copy link
Contributor

Fixes #26.

@marten-seemann marten-seemann requested a review from MarcoPolo July 1, 2022 18:41
@marten-seemann marten-seemann merged commit 38c507e into master Jul 1, 2022
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BufferPool.Get doesn't detect negative length values and blindly converts them into uint32(negative) which can trigger out of memory issues

2 participants