Skip to content

Fix overflow on 32-bit platforms.#2

Merged
Stebalien merged 1 commit intomasterfrom
kevina/fix-32-bit-overflow
Oct 4, 2018
Merged

Fix overflow on 32-bit platforms.#2
Stebalien merged 1 commit intomasterfrom
kevina/fix-32-bit-overflow

Conversation

@kevina
Copy link
Contributor

@kevina kevina commented Oct 4, 2018 •
edited
Loading

This fixes a compile error in 32-bit platforms:

# github.com/libp2p/go-buffer-pool
./pool.go:55:12: constant 4294967296 overflows int
./pool.go:68:31: constant 4294967296 overflows int

Tested using go version go1.10.4 linux/386.

Closes #1

CC @Stebalien

@ghost ghost assigned kevina Oct 4, 2018
@ghost ghost added the status/in-progress In progress label Oct 4, 2018
@kevina kevina requested review from Stebalien October 4, 2018 06:40
@kevina kevina mentioned this pull request Oct 4, 2018
Merged
@Stebalien Stebalien merged commit e8a991d into master Oct 4, 2018
@ghost ghost removed the status/in-progress In progress label Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees

@kevina kevina

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overflow on 32 bits platforms.

2 participants

@kevina @Stebalien