Updated Lithuanian 8-dots table, added a test for it.#218
Conversation
egli
left a comment
There was a problem hiding this comment.
I do not know Lithuanian, but the patch seems of fantastic quality: tests are there, well commented, Makefiles are updated. The only thing that is missing is a NEWS entry :-). But I can take care of that.
Thanks for your contribution
|
Glad you liked it. :) |
|
Oh, by the way... |
|
To my knowledge we do not share any patches with brltty. They might watch our repo, but to be safe I'd submit a PR to them as well |
|
The hyphenation library is another question. Generally I think we'd like to stick to LGPL code and tables. As far as I know the existing hyphenation tables are either created specifically for liblouis, as is the case for the danish hyphenation table, or they originate from OpenOffice and are licensed under LGPL. The licensing of the hyphenation tables is a bit murky, see the wiki page on table licensing. On the other hand according to the Free Software Foundation including hyphenation tables constitutes "mere aggregation", see #26 (comment), which means that we could legally include hyphenation tables with a different license as long as this license allows for redistribution. So ideally we should extend liblouis to use standard hyphenation tables. Failing that I guess we could add the Lithuanian hyphenation dictionary. |
|
Note that Liblouis can't make use of LaTeX tables, only OpenOffice.org tables. (I assume you are talking about a LaTeX table because you mentioned their license). The two type of tables have a similar format, and OpenOffice.org tables can be generated from LaTeX tables, but Liblouis can't directly process the LaTeX format. |
That's exactly why the table I'm talking about is licensed like that. :) This hyphenation table was generated from LPPL-licensed TeX pattern files more than 10 years ago, and had't been changed until the last year when it was re-converted from the same original source following newer instructions. I suppose that means it is nearly perfect. :) This table (or its older version) is or was used by LibreOffice, Mozilla, OpenOffice.org and likely many other open-source projects. The project above (not LibO or AOO) is as close as it gets to being upstream source of this data, the only higher upstream being the original TeX patterns, which, it seems, haven't been changed since 2004 or perhaps even earlier either. EDIT: i lied a little. Current upstream of our hyphenation table is http://tug.org/svn/texhyphen/trunk/hyph-utf8/tex/generic/hyph-utf8/patterns/txt/, from where it was taken and converted to OpenOffice.org/LibreOffice format. Interestingly, this source seems to quote a different, much more permissive license for the hyphenation data. @egli: |
|
By the way, when preparing my test, I discovered that during test runs liblouis does not translate empty cells to an appropriate Unicode character (U+2800 BRAILLE PATTERN BLANK), but instead uses U+0020 SPACE. @egli, is this an oversight? |
|
@rimas-kudelis I don't know if this an oversight. Might be by design. I don't know the code well enough |
|
It is by design. (see also #208 (comment)) |
|
Well that confirms the status quo, but doesn't really explain the reasons behind the design decision, or even confirm that there was a decision at all. |
|
I'm sorry I don't have an explanation for it. (I didn't design it). |
No description provided.