Skip to content

IInitialize intialLogFileName#142

Closed
ArendArends wants to merge 1 commit into
liblouis:masterfrom
ArendArends:Logging-initialization
Closed

IInitialize intialLogFileName#142
ArendArends wants to merge 1 commit into
liblouis:masterfrom
ArendArends:Logging-initialization

Conversation

@ArendArends

@ArendArends ArendArends commented Nov 22, 2015

Copy link
Copy Markdown

Possible crash if initialLogFileName not initialized
In addition define of vsnprintf for old versions of MS Visual Studio compiler

@ArendArends
Update output positions during multi pass (forward translation only)
0bed3ef 
trace_translate , the general translation function in
lou_translateString.c calls translatePass for pass2, 3 and 4.
translatePass does currently not update the output positions. This
modification tries to handle this.
This may affect cursor position too.
@bertfrees

bertfrees commented Nov 24, 2015

Copy link
Copy Markdown
Member

Did something go wrong?

@ArendArends

ArendArends commented Nov 24, 2015

Copy link
Copy Markdown
Author

Hi Bert,
I wanted to make a new pull request for a change to logging.c, but I was struggling with GitHub and instead of making new pull rquest for logging.c the system seemed to repeat the earlier request for update output positions. In addition I made some typo's in the description.
When I saw that this went wrong I tried to remove the new pull request, but I could only close the last commit.
After that I tried to handle the logging.c file in a different way, but then it was added as a commit to my earlier commit of a few weeks ago.
I realize that I don't know well how to use GitHub. The first pull request went alright with some effort, but adding a second independent pull request gave me a headache.
I hope that you can sort it out.

Arend

@bertfrees

bertfrees commented Nov 24, 2015

Copy link
Copy Markdown
Member

Sure we'll figure it out. I see a commit on your master branch called: "Initialize initialLogFileName. also add define for old version of MS compiler". I think that is the one. Thanks!

This was referenced Nov 30, 2015
Closed
Closed
@weijinjinnihao weijinjinnihao mentioned this pull request Oct 23, 2025
Closed
@weijinjinnihao weijinjinnihao mentioned this pull request Nov 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ArendArends @bertfrees