-
-
Notifications
You must be signed in to change notification settings - Fork 254
Output positions not updated for pass2 rules #74
Copy link
Copy link
Closed
Labels
bugBug in the code (not in a table)Bug in the code (not in a table)needs testA YAML test is needed (and should be committed) to explain the bug or expected behavior of a tableA YAML test is needed (and should be committed) to explain the bug or expected behavior of a table
Milestone
Metadata
Metadata
Assignees
Labels
bugBug in the code (not in a table)Bug in the code (not in a table)needs testA YAML test is needed (and should be committed) to explain the bug or expected behavior of a tableA YAML test is needed (and should be committed) to explain the bug or expected behavior of a table
Type
Fields
Give feedbackNo fields configured for issues without a type.
When a pass2 rule reduces the number of Braille cells in the translation, the output positions are not updated and so the output positions array becomes wrong. In the worst case the output positions array can contain values which are invalid index values for the translation and so would lead to a crash/exception.
I have not tested this to see whether a pass2 rule which adds extra Braille cells also suffers from this bug, but at least in that case values in the output positions will still be valid index values for the translation and would not lead to a crash, it would just lead to incorrect mappings.