Merged
Conversation
teseoch
approved these changes
Feb 25, 2022
Contributor
|
@alecjacobson |
added 2 commits
February 26, 2022 17:30
…ibigl-python-bindings into alecjacobson/bump-libigl-v2.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libigl-python-bindings previously grabbed libigl from a v2.2.* commit from Dec 2020.
This PR bumps libigl to the recently released v2.4.0. In order to make this compile, a few additional changes are needed:
flip_avoiding_line_search's API to match the bug-fixed one in libigl v2.4.0point_in_polyandpolygon_mesh_to_triangle_mesh.cppI propose to merge this to get igl::core bindings for v2.4.0 in place. We could even create a corresponding release here.
Then, I plan to flesh out bindings for missing functions in the other modules of igl (predicates, etc.). We could do a minor release on this repo once those are in place.